Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Minor yum, permission and URL fixes #21

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

j0yu
Copy link

@j0yu j0yu commented Jun 3, 2019

  • Dockerfile: Fixed yum clean all from being part of the yum install arguments
  • build_docs.sh: Fixed permissions of generated docs from just root only
  • travis-generate-docs.py: Fallback to DOC_* before using dummy URL.
  • Version to release as? (need to edit changelog.md)

@j0yu
Copy link
Author

j0yu commented Jun 3, 2019

Not sure if CI build fails because we're merging from a fork, rather than a branch within shotgunsoftware/tk-doc-generator. Does not seem to be picking up shotgunsoftware's AWS_S3_ACCESS_KEY

------------------------------------------------------
Build completed.
------------------------------------------------------
INFO Exit code: 0
INFO Uploading build result to S3...
ERROR An exception was raised!
Traceback (most recent call last):
  File "./travis-generate-docs.py", line 225, in <module>
    main()
  File "./travis-generate-docs.py", line 177, in main
    aws_access_key_id=os.environ["AWS_S3_ACCESS_KEY"],
  File "/home/travis/virtualenv/python2.7.14/lib/python2.7/UserDict.py", line 40, in __getitem__
    raise KeyError(key)
KeyError: 'AWS_S3_ACCESS_KEY'
INFO Exiting with code 1.
The command "python ./travis-generate-docs.py" exited with 1.

@j0yu j0yu closed this Jun 6, 2019
@j0yu j0yu deleted the fix-build-docs-rwX-yum-clean-all branch June 6, 2019 15:53
@j0yu j0yu restored the fix-build-docs-rwX-yum-clean-all branch June 6, 2019 15:54
@j0yu j0yu reopened this Jun 6, 2019
@j0yu j0yu force-pushed the fix-build-docs-rwX-yum-clean-all branch from ebb8ebe to cdc8657 Compare June 7, 2019 13:39
@j0yu j0yu mentioned this pull request Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant